On 23/02/2016 21:33, Konstantin Kolinko wrote:
> 2016-02-23 23:50 GMT+03:00 <ma...@apache.org>:
>> Author: markt
>> Date: Tue Feb 23 20:50:28 2016
>> New Revision: 1731953
>>
>> URL: http://svn.apache.org/viewvc?rev=1731953&view=rev
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58283
>> Change the default download location for libraries during the build process
>> from /usr/share/java to ${user.home}/temp
>> Patch provided by Ahmed Hosni.
>>
>> Modified:
>> tomcat/trunk/build.properties.default
>> tomcat/trunk/webapps/docs/changelog.xml
>>
>> Modified: tomcat/trunk/build.properties.default
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1731953&r1=1731952&r2=1731953&view=diff
>> ==============================================================================
>> --- tomcat/trunk/build.properties.default (original)
>> +++ tomcat/trunk/build.properties.default Tue Feb 23 20:50:28 2016
>> @@ -74,9 +74,7 @@ trydownload.httpusecaches=true
>> # Please note this path must be absolute, not relative,
>> # as it is referenced with different working directory
>> # contexts by the various build scripts.
>> -base.path=/usr/share/java
>> -#base.path=C:/path/to/the/repository
>> -#base.path=/usr/local
>> +base.path=${user.home}/temp
>
>
> 1. The following files must be updated:
> BUILDING.txt
> /webapps/docs/building.html (building.xml)
Ack.
> 2. The location is odd
>
> I am -1 to name "temp" as in "${user.home}/temp" because there is no
> "temp" directory by default there (none on Windows 7, none on Fedora
> Linux, does anyone have it?), and the name "temp" is easy to confuse
> with directories created by the system. For a user it is hard to know
> what created that directory.
>
> Also I think on Windows users rarely visit the %USERPROFILE% directory.
>
> If we keep it in ${user.home} then maybe one of these names:
> ${user.home}/tomcat-lib-temp
> ${user.home}/tomcat-build-libs
tomcat-build-libs works for me.
> but maybe relative to the source directory, e.g. ../libraries, or
> libraries (in the source tree + svn:ignore, gitignore it),
It has to be absolute.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
