https://bz.apache.org/bugzilla/show_bug.cgi?id=48674

--- Comment #11 from Remy Maucherat <r...@apache.org> ---
(In reply to Christopher Schultz from comment #9)
> This can be a dangerous feature, for a couple of reasons.

The user has to add the storeconfig listener in his configuration to use this
patch. Then all this does is a JMX method call, which is most likely already
accessible elsewhere.

> I had a look at the StoreConfig-based patch, and I must admit that I got
> lost in the whole architecture at the point that I started reading code in
> the o.a.c.storeconfig package. There is very little javadoc explaining what
> the heck is going on. It looks quite over-engineered and has a lot of code
> that looks very similar across classes.

Maybe, but the Catalina structure is built using reflection with a lot of
special cases. It's a separate optional module, so feel free to rewrite it :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to