https://bz.apache.org/bugzilla/show_bug.cgi?id=59027

--- Comment #2 from csutherl <csuth...@redhat.com> ---
This enhancement was brought to my attention and seemed like a relatively easy
thing to add, so I gave it a shot. Instead of using the patch from the original
bug I re-implemented the request using StoreConfig. This makes the changes a
lot smaller and prevented functional duplication of code that already existed
in StoreConfig. Note that this patch isn't 100% complete; I'm looking for some
feedback on how I can resolve a couple of things before I would consider it
complete.

My original thought was to add a button next to each host that would be
available to persist the host's configuration, however I think the StoreConfig
interface Impl needs some changes to make that happen, so I'm just using
storeConfig to save the complete configuration. I left the button on the host
row because I couldn't figure out where else to put it (feedback please). Maybe
it should be a link at the top? I also just noticed when I was doing some
testing that there is no way to remove a host and persist that, so that
furthers the idea that the button should be somewhere else on the page.

If StoreConfig isn't enabled when you click the persist button it will provide
a failure message that suggests enabling it by catching the InstanceNotFound
exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to