2016-02-11 18:16 GMT+01:00 Christopher Schultz <ch...@christopherschultz.net >:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Mark, > > On 2/10/16 6:10 PM, Mark Thomas wrote: > > On 09/02/2016 14:22, ma...@apache.org wrote: > >> Author: markt Date: Tue Feb 9 14:22:29 2016 New Revision: > >> 1729390 > >> > >> URL: http://svn.apache.org/viewvc?rev=1729390&view=rev Log: > >> Refactor AuthenticatorBase to support future plans for the JASPIC > >> implementation. > > > > Just a heads up that I'm currently thinking I'm going to need to > > revert this. As I learn more about JASPIC the authenticate() > > doesn't look like the best integration point. invoke() looks > > better. > > > > However, I currently have bigger problems. JASPIC wants to be able > > to wrap requests and responses. Something that isn't possible in a > > Valve. I am currently looking at ways to make that work. > > A valve can wrap a request or a response. We just don't have the > classes in Tomcat right now to make that super easy. > > Classes like these: https://bz.apache.org/bugzilla/show_bug.cgi?id=45014 > > After the proposed update, a valve would have the ability to wrap [for the application, not for other valves]. I am still against straight wrapping. Rémy
