On 19/01/2016 02:25, Keiichi Fujino wrote: > 2016-01-18 22:13 GMT+09:00 <ma...@apache.org>: > >> Author: markt >> Date: Mon Jan 18 13:13:35 2016 >> New Revision: 1725263 >> >> URL: http://svn.apache.org/viewvc?rev=1725263&view=rev >> Log: >> Expand the session attribute filtering options >> - new option to filter based on implementation class of value >> - new option to log a warning message if an attribute is filtered out >> - always log a message at at least debug level if an attribute is filtered >> out
<snip/> > I think. > Since the cluster manager is cloned from a template, > we must implement the process of setting sessionAttributeNameFilter, > sessionAttributeValueClassNameFilter and > warnOnSessionAttributeFilterFailure in ClusterManagerBase.clone. > > I've already committed at r1725405. +1. Thanks. > The attributes of sessionAttributeNameFilter, > sessionAttributeValueClassNameFilter and > warnOnSessionAttributeFilterFailure are described in the document as each > of the attributes of Deltamanager and BackupManager. > Is this an intentional distinction? > Do these attributes documents in the "Common Attributes" section? Yes, it was intentional. While we might not always have followed it in the past, the rule is meant to be only attributes defined in the interface (i.e. ones that will be in every implementation) go in the Common Attributes section. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
