Author: violetagg
Date: Tue Jan 5 20:38:01 2016
New Revision: 1723155
URL: http://svn.apache.org/viewvc?rev=1723155&view=rev
Log:
Update findbugs false positive - reliance on default encoding
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1723155&r1=1723154&r2=1723155&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Tue Jan 5 20:38:01
2016
@@ -141,6 +141,13 @@
<Bug code="RCN"/>
</Match>
<Match>
+ <!-- the platform default encoding is a fallback when calculating the
+ lenght of the string -->
+ <Class name="org.apache.catalina.connector.Request"/>
+ <Method name="parseParts"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- JNI library can only be loaded once so statics are appropriate -->
<Class name="org.apache.catalina.core.AprLifecycleListener" />
<Bug code="ST" />
@@ -216,6 +223,13 @@
<Bug code="RCN"/>
</Match>
<Match>
+ <!-- If encoding is specified it will be used,
+ otherwise platform default encoding will be used -->
+ <Class name="org.apache.catalina.realm.RealmBase"/>
+ <Method name="Digest"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- The header value is safe -->
<Class name="org.apache.catalina.servlets.DefaultServlet" />
<Method name="doDirectoryRedirect" />
@@ -254,6 +268,20 @@
<Bug code="NP" />
</Match>
<Match>
+ <!-- If encoding is specified it will be used,
+ otherwise platform default encoding will be used -->
+ <Class name="org.apache.catalina.ssi.SSIServlet"/>
+ <Method name="processSSI"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
+ <!-- If encoding is specified it will be used,
+ otherwise platform default encoding will be used -->
+ <Class name="org.apache.catalina.ssi.SSIServletExternalResolver"/>
+ <Method name="getFileText"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- Catalina isn't used when embedding -->
<Class name="org.apache.catalina.startup.Catalina" />
<Method name="stopServer" />
@@ -331,6 +359,12 @@
<Bug code="UG" />
</Match>
<Match>
+ <!-- the platform default encoding is a fallback -->
+ <Class name="org.apache.catalina.util.URLEncoder"/>
+ <Method name="encode"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- request.getRemoteHost() can be null because
o.a.t.util.buf.MessageBytes.toString() can return NULL -->
<Class
name="org.apache.catalina.valves.AbstractAccessLogValve$HostElement"/>
@@ -518,6 +552,12 @@
<Bug code="NP" />
</Match>
<Match>
+ <!-- the platform default encoding is a fallback -->
+ <Class name="org.apache.jasper.runtime.JspRuntimeLibrary"/>
+ <Method name="URLEncode"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- Use of == is deliberate, String.intern() is used -->
<Class name="org.apache.jasper.xmlparser.XMLEncodingDetector"/>
<Method name="scanXMLDeclOrTextDecl"/>
@@ -531,6 +571,13 @@
<Bug code="OBL"/>
</Match>
<Match>
+ <!-- If encoding is specified it will be used,
+ otherwise platform default encoding will be used -->
+ <Class name="org.apache.juli.FileHandler"/>
+ <Method name="openWriter"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- Simpler to catch Exception than to create dummy implementations of the
necessary exception hierarchy -->
<Class name="org.apache.naming.factory.SendMailFactory$1" />
@@ -654,6 +701,12 @@
<Bug code="RCN" />
</Match>
<Match>
+ <!-- the platform default encoding is a fallback -->
+ <Class name="org.apache.tomcat.util.buf.UDecoder"/>
+ <Method name="URLDecode"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- NPE is desired as it indicates an error condition -->
<Class name="org.apache.tomcat.util.digester.CallMethodRule"/>
<Method name="end"/>
@@ -675,6 +728,24 @@
<Bug code="SF" />
</Match>
<Match>
+ <!-- the platform default encoding is a fallback -->
+ <Class name="org.apache.tomcat.util.http.fileupload.MultipartStream"/>
+ <Method name="readHeaders"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
+ <!-- the platform default encoding is a fallback -->
+ <Class name="org.apache.tomcat.util.http.fileupload.disk.DiskFileItem"/>
+ <Method name="getString"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
+ <!-- the platform default encoding is deliberate -->
+ <Class name="org.apache.tomcat.util.http.fileupload.util.Streams"/>
+ <Method name="asString"/>
+ <Bug code="Dm" />
+ </Match>
+ <Match>
<!-- Fall-through expected -->
<Class name="org.apache.tomcat.util.http.parser.Cookie" />
<Or>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
