2016-01-05 5:17 GMT+02:00 <kkoli...@apache.org>: > > Author: kkolinko > Date: Tue Jan 5 03:17:36 2016 > New Revision: 1722996 > > URL: http://svn.apache.org/viewvc?rev=1722996&view=rev > Log: > Mark ReadWriteLock in modeler classes as final. (In review of r1722660/r1722661/r1722663 of Tomcat 7). > > The lock itself is accessed by multiple threads, thus it is better to mark such field as final to ensure consistency. >
Thanks for the review Violeta > Modified: > tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java > tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java > > Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java?rev=1722996&r1=1722995&r2=1722996&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java (original) > +++ tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java Tue Jan 5 03:17:36 2016 > @@ -41,7 +41,7 @@ public class NotificationInfo extends Fe > */ > transient MBeanNotificationInfo info = null; > protected String notifTypes[] = new String[0]; > - protected ReadWriteLock notifTypesLock = new ReentrantReadWriteLock(); > + protected final ReadWriteLock notifTypesLock = new ReentrantReadWriteLock(); > > // ------------------------------------------------------------- Properties > > > Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java?rev=1722996&r1=1722995&r2=1722996&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java (original) > +++ tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java Tue Jan 5 03:17:36 2016 > @@ -48,7 +48,7 @@ public class OperationInfo extends Featu > > protected String impact = "UNKNOWN"; > protected String role = "operation"; > - protected ReadWriteLock parametersLock = new ReentrantReadWriteLock(); > + protected final ReadWriteLock parametersLock = new ReentrantReadWriteLock(); > protected ParameterInfo parameters[] = new ParameterInfo[0]; > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
