Author: markt
Date: Fri Dec 11 08:29:51 2015
New Revision: 1719278
URL: http://svn.apache.org/viewvc?rev=1719278&view=rev
Log:
Fix some FindBugs false positives and correct order of entries.
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1719278&r1=1719277&r2=1719278&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Fri Dec 11 08:29:51
2015
@@ -113,7 +113,7 @@
<Match>
<!-- The header value is safe -->
<Class name="org.apache.catalina.servlets.DefaultServlet" />
- <Method name="serveResource" />
+ <Method name="doDirectoryRedirect" />
<Bug pattern="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER" />
</Match>
<Match>
@@ -768,15 +768,6 @@
<Bug pattern="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER"/>
</Match>
<Match>
- <!-- Return value of latch is intentionally ignored -->
- <Or>
- <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClient"/>
- <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClientSSL"/>
- </Or>
- <Method name="testConnectToServerEndpoint"/>
- <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
- </Match>
- <Match>
<Class name="org.apache.tomcat.util.net.TestSsl" />
<Or>
<Method name="testRenegotiateFail" />
@@ -801,6 +792,21 @@
</Or>
</Match>
<Match>
+ <!-- Return value of latch is intentionally ignored -->
+ <Or>
+ <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClient"/>
+ <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClientSSL"/>
+ </Or>
+ <Method name="testConnectToServerEndpoint"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
+ </Match>
+ <Match>
+ <!-- Statics are used deliberately as they are simpler -->
+ <Class name="org.apache.tomcat.websocket.server.TestClose" />
+ <Method name="setUp" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+ </Match>
+ <Match>
<!-- Code is deliberately unused -->
<Class name="org.apache.tomcat.websocket.server.TestUriTemplate" />
<Or>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
