Author: markt
Date: Wed Nov 25 15:26:09 2015
New Revision: 1716439
URL: http://svn.apache.org/viewvc?rev=1716439&view=rev
Log:
Add a TODO
Modified:
tomcat/trunk/java/org/apache/tomcat/buildutil/SignCode.java
Modified: tomcat/trunk/java/org/apache/tomcat/buildutil/SignCode.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/buildutil/SignCode.java?rev=1716439&r1=1716438&r2=1716439&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/buildutil/SignCode.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/buildutil/SignCode.java Wed Nov 25
15:26:09 2015
@@ -349,6 +349,9 @@ public class SignCode extends Task {
private static String getApplicationString(List<String> fileNames,
List<File> files)
throws IOException {
// 16 MB should be more than enough for Tomcat
+ // TODO: Refactoring this entire class so it uses streaming rather than
+ // buffering the entire set of files in memory would make it more
+ // widely useful.
ByteArrayOutputStream baos = new ByteArrayOutputStream(16 * 1024 *
1024);
try (ZipOutputStream zos = new ZipOutputStream(baos)) {
byte[] buf = new byte[32 * 1024];
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
