https://bz.apache.org/bugzilla/show_bug.cgi?id=58625
Bug ID: 58625
Summary: Failed to detect war change
Product: Tomcat 8
Version: 8.0.28
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: loic.ou...@gmail.com
In the case where the war is not completly expanded in the work directory, the
code introduce by the commit
http://svn.apache.org/viewvc?view=revision&revision=1663784 doesn't catch the
case where the file 'war_tracker' is not present and do not re-expand the war
file accordingly.
We can see the code in org.apache.catalina.startup.ExpandWar.java:
// Check to see of the WAR has been expanded previously
if (docBase.exists()) {
// A WAR was expanded. Tomcat will have set the last modified
// time of warTracker file to the last modified time of the WAR so
// changes to the WAR while Tomcat is stopped can be detected
if (!warTracker.exists() || warTracker.lastModified() ==
warLastModified) {
// No (detectable) changes to the WAR
success = true;
return (docBase.getAbsolutePath());
}
The test should be more thinner :
if (warTracker.exists() && warTracker.lastModified() == warLastModified) {
// No (detectable) changes to the WAR
success = true;
return (docBase.getAbsolutePath());
}
I don't catch when this use case appear exactly, but I face this problem one or
two times a day.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
