2015-11-07 21:35 GMT+03:00 Rémy Maucherat <r...@apache.org>: > 2015-11-07 18:17 GMT+01:00 <kkoli...@apache.org>: > >> Author: kkolinko >> Date: Sat Nov 7 17:17:55 2015 >> New Revision: 1713158 >> >> URL: http://svn.apache.org/viewvc?rev=1713158&view=rev >> Log: >> Copy test implementation from Tomcat 7. >> This a) uses logging instead of System.out, >> b) validates result of the test and fail()s, instead of just printing a >> message onto System.out >> >> When I voted for CTR on 6, it was agreed upon that only critical fixes > would go in 6. Obviously, there's no regression risk with the testsuite, > but what is the rationale with such an upgrade ?
On commit policy ---------- There is no such agreement as "only critical fixes would go in 6" There was none both either before nor after the CTR vote. In my opinion, any good fixes that do not introduce new bugs are OK. Agenda ---------- My ultimate goal is to improve test coverage of Tomcat 6. There is tomcat6-testing branch that I once started [1], you can look at BRANCH-README.txt there [1] https://svn.apache.org/viewvc/tomcat/tc6.0.x/branches/tomcat6-testing/ I do not know whether that goal of adding new tests is reachable. As the first and simple goal I am reviewing the existing tests, converting them to JUnit 4 and updating them by using Tomcat 7 as the reference. I am converting th test to JUnit 4 for the following reasons: a. It makes it easier to compare current code with Tomcat 7 b. It allows to use @Ignore and assumeX..() to skip tests Tribes ---------- I am running all the tests locally (starting JUnit from within Eclipse IDE) so to do not break anything. Initial state before staring this work was: all tests were completing successfully, except 2 tests in tribes: 1) o.a.c.tribes.test.channel.TestDataIntegrity.testDataSendASYNCM() fails with: junit.framework.AssertionFailedError: Checking success messages. expected:<10000> but was:<1835> 2) o.a.c.tribes.test.channel.TestRemoteProcessException.testDataSendSYNCACK() fails with: ChannelException: Send failed, attempt:2 max:1; Faulty members:tcp://{my id address here}:4001; In Tomcat 7 there was some work to investigate test failures and to improve stability of tribes tests several years ago (in March 2012). If we are going to keep these tests as part of test suite, I think it is important to backport those test fixes. This specific commit (r1713158) is one of those backports. As just now I am testing TestDataIntegrity, I see that its failure is not fixed by simple backport of Tomcat 7 changes in the test. Some fix in the tribes itself is needed, as the test runs successfully in Tomcat 7. Fixing the tribes itself is out of my scope. My plans on completing the current task ------------------------------------------------------------ 1. Convert remaining tests to JUnit 4. It is almost done, there are just several of them remaining. 2. If we ever configure to run Tomcat 6 tests automatically, we are going to skip those failing tests. Tomcat 7 does in its build.xml: <!-- Exclude the tests known to fail --> <exclude name="org/apache/catalina/tribes/test/**" /> tribes/test/** is a subset of Tribes tests. Most of the test have been moved to other packages, tribes/group, /io, /membership. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
