https://bz.apache.org/bugzilla/show_bug.cgi?id=58590

--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> ---
Two things:

1. If possible, look at the UserDatabase class to see if you can get that to
reload instead of the Realm. If you think about e.g. DatsSourceRealm, it makes
more sense to "reload" the data source and not the realm itself.

2. Instead of calling _lastUpdate.getTime() each time, why not just store the
native long value returned by it? (Also, you can then simply store the value of
_usersFile.lastModified instead of creating a new Date object).

As for Konstantin being picky about your implementation... we get to be as
picky about patch submissions as the submitters are willing to tolerate. Since
you are motivated to get your patch accepted, we just want to make sure it's as
high-quality as possible.

Thanks for your contributions!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to