2015-10-06 16:43 GMT+03:00 Mark Thomas <ma...@apache.org>: > On 06/10/2015 14:14, Benjamin Gandon wrote: >> Hi there, >> >> Working on my JULI-to-SLF4J bridge library (see >> <https://github.com/bgandon/juli-to-slf4>), >> I have identified a small and invisible issue in the jar packaging of >> tomcat-juli-adapters in the extras. >> >> Indeed, the LogFactoryImpl is shipped with the adapters, but it is not >> supposed to. >> 1. Because it is already shipped with the tomcat-juli jar. >> 2. Because the ${files.tomcat-extras-juli-adapters} in build.xml specifies >> an exclusion on it. >> >> But the exclusion is ineffective because it lacks a star at the end. >> >> The issue is invisible because of class loading delegation. Children class >> loaders accessing the adapters favor delegation to the System loader. >> So the LogFactoryImpl from tomcat-juli (System classpath) always masks the >> one erroneously shipped with tomcat-juli-adapters (Catalina classpath). >> > >> Do you need a BZ issue for this? > > No need. If a patch isn't picked up fairly quickly (say within 24 hours) > I'd recommend using a pull request or opening a Bugzilla issue since > both those mechanisms reduce the chances of an issue being forgotten about. > >> Or could someone just commit the fix for me please? I include the diff below. > > Done. For trunk, 8.0.x and 7.0.x. >
Fixed for Tomcat 6 as well (r1712571) Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
