https://bz.apache.org/bugzilla/show_bug.cgi?id=58564

            Bug ID: 58564
           Summary: Simplify
                    Boolean.parseBoolean(System.getProperty("xxx"),
                    "false") to Boolean.getBoolean("xxx")
           Product: Tomcat 8
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: huxing.zh...@gmail.com

Hi folks,

in svn commit: r1710933
or github commit:
https://github.com/apache/tomcat/commit/55c52b0f0697d2e12d9ce842d0f7f0df20da1ff7

I think the following code snippet:

Boolean.parseBoolean(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
"false"));

is equivalent to:

Boolean.getBoolean("org.apache.catalina.STRICT_SERVLET_COMPLIANCE");

which is simpler.

According to the documentation:
https://docs.oracle.com/javase/6/docs/api/java/lang/Boolean.html

static boolean getBoolean(String name):
Returns true if and only if the system property named by the argument exists
and is equal to the string "true".

How do you guys think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to