https://bz.apache.org/bugzilla/show_bug.cgi?id=58540

            Bug ID: 58540
           Summary: Request setCharacterEncoding has unused code
           Product: Tomcat 8
           Version: trunk
          Hardware: Macintosh
                OS: Mac OS X 10.1
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: anth...@whitford.com

Created attachment 33212
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33212&action=edit
This patch removes the unused buffer.

The 'buffer' variable is unused and can be removed.  (I suspect it is a remnant
of some past code.) 


    @Override
    public void setCharacterEncoding(String enc)
        throws UnsupportedEncodingException {

        if (usingReader) {
            return;
        }

        // Ensure that the specified encoding is valid
        byte buffer[] = new byte[1];
        buffer[0] = (byte) 'a';

        // Confirm that the encoding name is valid
        B2CConverter.getCharset(enc);

        // Save the validated encoding
        coyoteRequest.setCharacterEncoding(enc);
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to