https://bz.apache.org/bugzilla/show_bug.cgi?id=58537
Bug ID: 58537
Summary: ExtendedAccessLogValve inner AccessLogElement classes
can be static
Product: Tomcat 8
Version: trunk
Hardware: PC
OS: Mac OS X 10.1
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: anth...@whitford.com
Created attachment 33211
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33211&action=edit
Add the static keyword to the inner AccessLogElement classes
There are several inner classes defined that subclass AccessLogElement that are
not defined as static.
Since the inner classes do not use its embedded reference to the object which
created it, the class may be made static to avoid keeping the reference to the
creator object alive longer than necessary, and keeping the class instances
lean.
See
http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
