https://bz.apache.org/bugzilla/show_bug.cgi?id=58382

            Bug ID: 58382
           Summary: Data race inside non-thread-safe HashMap
                    org.apache.catalina.tribes.membership.Membership.map
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: yilong...@runtimeverification.com

Reported by RV-Predict (a dynamic race detector) when running the test suite:
Data race on field java.util.HashMap.$state: {{{
    Concurrent write in thread T189 (locks held: {})
 ---->  at
org.apache.catalina.tribes.membership.Membership.removeMember(Membership.java:167)
        at
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.memberDisappeared(NonBlockingCoordinator.java:525)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector.memberDisappeared(TcpFailureDetector.java:176)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.DomainFilterInterceptor.memberDisappeared(DomainFilterInterceptor.java:79)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.ChannelCoordinator.memberDisappeared(ChannelCoordinator.java:251)
        at
org.apache.catalina.tribes.membership.McastService.memberDisappeared(McastService.java:471)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$1.run(McastServiceImpl.java:383)
    T189 is created by T185
        at
java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:1010)

    Concurrent read in thread T1 (locks held: {Monitor@2b72a0b3,
Monitor@16307bd4, Monitor@22551e94})
 ---->  at
org.apache.catalina.tribes.membership.Membership.reset(Membership.java:106)
        - locked Monitor@22551e94 at
org.apache.catalina.tribes.membership.Membership.reset(Membership.java:n/a)
        at
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.stop(NonBlockingCoordinator.java:472)
        - locked Monitor@16307bd4 at
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.stop(NonBlockingCoordinator.java:463)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.stop(ChannelInterceptorBase.java:171)
        at
org.apache.catalina.tribes.group.GroupChannel.stop(GroupChannel.java:444)
        - locked Monitor@2b72a0b3 at
org.apache.catalina.tribes.group.GroupChannel.stop(GroupChannel.java:n/a)
        at
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.tearDown(TestNonBlockingCoordinator.java:127)
        at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
        at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
        at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
        at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
        at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)
        at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:535)
        at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1182)
        at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1033)
    T1 is the main thread
}}} 

Data race on field java.util.HashMap.$state: {{{
    Concurrent write in thread T53 (locks held: {})
 ---->  at
org.apache.catalina.tribes.membership.Membership.removeMember(Membership.java:167)
        at
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.memberDisappeared(NonBlockingCoordinator.java:525)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector.memberDisappeared(TcpFailureDetector.java:176)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.DomainFilterInterceptor.memberDisappeared(DomainFilterInterceptor.java:79)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.ChannelCoordinator.memberDisappeared(ChannelCoordinator.java:251)
        at
org.apache.catalina.tribes.membership.McastService.memberDisappeared(McastService.java:471)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$1.run(McastServiceImpl.java:383)
    T53 is created by T32
        at
java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:1010)

    Concurrent read in thread T55 (locks held: {})
 ---->  at
org.apache.catalina.tribes.membership.Membership.removeMember(Membership.java:167)
        at
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.memberDisappeared(NonBlockingCoordinator.java:525)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector.memberDisappeared(TcpFailureDetector.java:176)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.interceptors.DomainFilterInterceptor.memberDisappeared(DomainFilterInterceptor.java:79)
        at
org.apache.catalina.tribes.group.ChannelInterceptorBase.memberDisappeared(ChannelInterceptorBase.java:93)
        at
org.apache.catalina.tribes.group.ChannelCoordinator.memberDisappeared(ChannelCoordinator.java:251)
        at
org.apache.catalina.tribes.membership.McastService.memberDisappeared(McastService.java:471)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$1.run(McastServiceImpl.java:383)
    T55 is created by T32
        at
java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:1010)
}}} 

Data race on field java.util.HashMap.$state: {{{
    Concurrent read in thread T250 (locks held: {Monitor@2c4e42fe,
Monitor@ebeabe7})
 ---->  at
org.apache.catalina.tribes.membership.Membership.expire(Membership.java:200)
        - locked Monitor@ebeabe7 at
org.apache.catalina.tribes.membership.Membership.expire(Membership.java:n/a)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.checkExpired(McastServiceImpl.java:455)
        - locked Monitor@2c4e42fe at
org.apache.catalina.tribes.membership.McastServiceImpl.checkExpired(McastServiceImpl.java:454)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.send(McastServiceImpl.java:512)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.send(McastServiceImpl.java:487)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$SenderThread.run(McastServiceImpl.java:575)
    T250 is created by T165
        at
org.apache.catalina.tribes.membership.McastServiceImpl.start(McastServiceImpl.java:280)

    Concurrent write in thread T185 (locks held: {})
 ---->  at
org.apache.catalina.tribes.membership.Membership.removeMember(Membership.java:167)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.memberDataReceived(McastServiceImpl.java:376)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.receive(McastServiceImpl.java:356)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$ReceiverThread.run(McastServiceImpl.java:541)
    T185 is created by T165
        at
org.apache.catalina.tribes.membership.McastServiceImpl.start(McastServiceImpl.java:269)
}}} 

Data race on field java.util.HashMap.$state: {{{
    Concurrent read in thread T250 (locks held: {Monitor@2c4e42fe,
Monitor@ebeabe7})
 ---->  at
org.apache.catalina.tribes.membership.Membership.expire(Membership.java:201)
        - locked Monitor@ebeabe7 at
org.apache.catalina.tribes.membership.Membership.expire(Membership.java:n/a)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.checkExpired(McastServiceImpl.java:455)
        - locked Monitor@2c4e42fe at
org.apache.catalina.tribes.membership.McastServiceImpl.checkExpired(McastServiceImpl.java:454)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.send(McastServiceImpl.java:512)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.send(McastServiceImpl.java:487)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$SenderThread.run(McastServiceImpl.java:575)
    T250 is created by T165
        at
org.apache.catalina.tribes.membership.McastServiceImpl.start(McastServiceImpl.java:280)

    Concurrent write in thread T185 (locks held: {})
 ---->  at
org.apache.catalina.tribes.membership.Membership.removeMember(Membership.java:167)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.memberDataReceived(McastServiceImpl.java:376)
        at
org.apache.catalina.tribes.membership.McastServiceImpl.receive(McastServiceImpl.java:356)
        at
org.apache.catalina.tribes.membership.McastServiceImpl$ReceiverThread.run(McastServiceImpl.java:541)
    T185 is created by T165
        at
org.apache.catalina.tribes.membership.McastServiceImpl.start(McastServiceImpl.java:269)
}}}

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to