Costin Manolache wrote:
Few questions:
- why is this needed ( i.e. what problem with the ThreadPoolExecutor is it
solving ) ?
- who is cleaning worker threads ( after a peak ) ?
- it would be good to have some comments on the stack - what happens on
push() if end == workers.length for
example, or why this won't happen
- try/catch may be good in worker.run, or you may miss recycle and cleanup
- why not just add executor interface to the existing ( and relatively well
tested ) thread pool ??
- hooks in TPExecutor are nice and may be useful...
I think it would be ok to add this to sandbox for example, but not very
sure
about adding it to the main tree.
Doesn't look very solid....
After experimenting, I think it's useless. I will use the executor
interface for full featured global thread pools. For simpler thread
pools, the API does not make sense.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
