On 3/27/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > Hi, > > So the new repository is here: > http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ > > - I did my own connector refactorings very recently, and the result can > be seen here (I removed SSL support in that code, but it could be left > in easily) for the java.io endpoint: > > http://anonsvn.labs.jboss.com/trunk/labs/jbossweb/src/share/classes/org/apache/tomcat/util/net/JIoEndpoint.java > This increases the commonality between the two endpoints, and IMO is the > right first step to start code sharing. Since it is Java 5, I will also > see if I can add ways to specify an Executor for use by the endpoint for > its worker threads (I expect so-so performance, but it could allow > things like a single thread pool for the whole server).
+1 on increasing the commonality between endpoints, and +1 on removing pure tls and the entire SSL-support from the base connector - if anyone needs different SSL stack it can be added back, but with a different abstraction. I'll compare your refactoring with mine ( in sandbox ), I have no problem with droping my code, but since we have 2 implementations it's good to compare and see if maybe there are good things in both :-) - The Jasper sources for JSP 2.1 are also in that repository. > > - (from the get rid of dependencies department) Should PureTLS support > stay ? > > - I will happily write the build script, which is going to be an order > of magnitude simpler. Let me know if you need help :-). The script in sandbox can already build all the base tomcat, it's just not packing it in the old format ( since it's purpose is to avoid the jar and directory mess :-) If you don't mind, I think we should have the single-jar option in the main build file, even if we won't release it this way. Any comment on the 'direct' commons-logging ? Costin
