Hi, The reason your patch hasn't been applied yet (or at least, the reason I haven't applied it yet, and I have looked at it once your twice) is that I'm sure the copy operation you remove is really redundant in all cases.
The copy operation seems to have been added as part of revision 303270 committed on Thu Sep 23 07:03:27 2004 UTC by Remy. It's been nearly a year and half since then, with no complaints about this code except yours, so it seems to work for the majority of users. Accordingly, before we go and apply your patch, we'd need to be convinced that it doesn't introduce a regression failure. For reference, Remy's commit notes on the patch read: - Fix some deprecation warnings. - Fix bug 31264: deploy should now behave correctly. Also move the writing of the WAR inside the isServiced block, so that if the uploading takes time, the auto deployer doesn't try to deploy it. - Add any deployment operation inside a try/finally block so that serviced is set back to false for the management operation, regardless of what occurs. There shouldn't be any unexpected exceptions thrown out there, but any problem would prevent further management of the application. Yoav On 3/21/06, Haroon Rafique <[EMAIL PROTECTED]> wrote: > Dear Tomcat Developers, > > I noticed that 5.5.16 has beeen voted as stable (no major issues) on March > 15th. To deploy this release in production I will have to make a custom > distribution (yet once again). The reason for this is that a simple bug in > ManagerServlet (reported by myself) has still not been fixed. Before I can > deploy a vanilla release to production, I need to have this bug committed. > I reported this bug 36847 in the tomcat 5.5.9 days (2005-09-28) and I also > did the analysis and provided a patch. > http://issues.apache.org/bugzilla/show_bug.cgi?id=36847 > > Would a tomcat developer be kind enough to take a look at the bug and > commit it, so that it makes it into the next stable release? I have sent > reminder emails before but have gotten no response. Is there anything else > I can do? > > Thanks In Advance, > -- > Haroon Rafique > <[EMAIL PROTECTED]> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Yoav Shapira Nimalex LLC 1 Mifflin Place, Suite 310 Cambridge, MA, USA [EMAIL PROTECTED] / www.yoavshapira.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
