The current os.c patch works well at mac os x. and currently the IS_UNIX
flag is enough.
But my research for more mac os x system info is hard. Help is needed...

Thanks
peter



Am 17.03.2006 um 11:10 schrieb Mladen Turk:

Jim Jagielski wrote:
I'm thinking... the behavior we want is that non-Windows
OSs want the APR_SO_REUSEADDR before the bind; Windows
wants it after. So checking for (OS.IS_UNIX) at
one point (for the former) and then (OS.IS_WIN32 || OS.IS_WIN64)
(for the later) is misleading, and doesn't match what
we do elsewhere. So why not make the former test
    !(OS.IS_WIN32 || OS.IS_WIN64)
instead? This should also fix the MacOS bug as well.
Now that flags are correctly initialized, there is no need
for that. MacOS will be reported as 'IS_UNIX'.
Of course we can add IS_MACOS once when Peter finishes
MacOS system info, but it will still be reported as IS_UNIX
beside IS_MACOS, just like IS_LINUX or IS_SOLARIS.

We can change the later test for
(OS.IS_WIN32 || OS.IS_WIN64) to !OS.IS_UNIX
but it wouldn't change anything functional.


Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to