DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38658>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38658





------- Additional Comments From [EMAIL PROTECTED]  2006-02-17 05:17 -------
After installing tomcat 5.5 and source, some very substantial changes from 5.0
required the following:

org.apache.catalina.connector.ResponseFacade:

import org.apache.catalina.connector.Response;
public Response getResponse() {
  return response;
}

org.apache.catalina.connector.RequestFacade:

import org.apache.catalina.connector.Request;
public Request getRequest() {
  return (Request)request;
}

org.apache.catalina.connector.AuthenticatorBase:

import org.apache.catalina.connector.ResponseFacade;
import org.apache.catalina.connector.RequestFacade;

public void doLogin(HttpServletRequest request, HttpServletResponse response,
Principal principal) 
{
  register(((RequestFacade)request).getRequest(),
  ((ResponseFacade)response).getResponse(),
  principal, "FORM", null, null);
}

Also, in the 'tryLogin' example below:
session.setNote(Constants.SESS_PASSWORD_NOTE, pass);

password now cannot be null; I presume an empty String is safe - it works okay.

The fact that HttpResponse and HttpRequest no longer exist (code cleanup) also
exemplifies the usefulness of a simple public interface into the login state --
if one had built modules that extended AuthenticatorBase and required
HttpResponse/HttpRequest those (as in this case), one would have to maintain two
versions (for 5 and 5.5).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to