Bill Barker wrote:
Author: remm
Date: Mon Jan 23 17:13:19 2006
New Revision: 371765

URL: http://svn.apache.org/viewcvs?rev=371765&view=rev
Log:
- Remove nonsensical systematic inclusion on ISO-8859-1 charset in the content type, which is noth
  useless and inefficient.


-1
Sending the charset used by the Writer is very clearly required by the
servlet spec.

Thanks, I expected no less coming from you :) I will revert my patch.

A couple questions for your enjoyment:
1) Is this relevant or irrelevant from the HTTP specification perspective ?
2) Does this mean we're running the following ultra efficient code (I don't even know why I accepted this stuff back then. It must have been that this has been done gradually through many many commits) for each request that uses a writer ?

    public String getContentType() {

        String ret = contentType;

        if (ret != null
            && characterEncoding != null
            && charsetSet) {
            ret = ret + ";charset=" + characterEncoding;
        }

        return ret;
    }

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to