Author: billbarker
Date: Fri Dec 9 18:53:21 2005
New Revision: 355701
URL: http://svn.apache.org/viewcvs?rev=355701&view=rev
Log:
Fix regression where the magic role '*' was denying all access.
I had forgotten that '*' isn't stored as a role, so Tomcat was treating it like
<auth-constraint />.
Fix for Bug #37852
Submitted By: xrcat (xrcat at mailinator.com)
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
URL:
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java?rev=355701&r1=355700&r2=355701&view=diff
==============================================================================
---
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
(original)
+++
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
Fri Dec 9 18:53:21 2005
@@ -738,7 +738,7 @@
if (log.isDebugEnabled())
log.debug(" Checking roles " + principal);
- if (roles.length == 0) {
+ if (roles.length == 0 && !constraint.getAllRoles()) {
if(constraint.getAuthConstraint()) {
if( log.isDebugEnabled() )
log.debug("No roles ");
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
