[
https://issues.apache.org/jira/browse/TINKERPOP-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265147#comment-15265147
]
ASF GitHub Bot commented on TINKERPOP-1267:
-------------------------------------------
Github user pluradj commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/294#issuecomment-215934896
Other than that nit, everything else checked out ok.
The fix for that is trivial, so I'll go ahead and vote.
I inspected the code, reviewed the docs, ran the tests.
VOTE: +1
> Configure Console for no timeout on remote requests
> ---------------------------------------------------
>
> Key: TINKERPOP-1267
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1267
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
> Affects Versions: 3.1.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.3
>
>
> The console comes with a default timeout of 3 minutes for remote requests to
> Gremlin Server. You can change that value with:
> {code}
> :remote config timeout 60000
> {code}
> or you can make it "basically" indefinite with:
> {code}
> :remote config timeout max
> {code}
> I think "max" is kinda weird now that I look at it. That basically sets a
> time out for {{Integer.MAX_VALUE}} when you really just want to wait
> indefinitely and have no timeout at all. I guess "max" is just a sort of a
> bad word. It seems like it would be good to deprecate "max" in favor of:
> {code}
> :remote config timeout none
> {code}
> which is more in line with what someone actually wants to have when they are
> doing "max".
> Change the default timeout from 3 minutes to "none". It seems to be the more
> expected default. Can't think of a circumstance in the context of the
> console, where the client shouldn't just wait for the server's response.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
