[
https://issues.apache.org/jira/browse/TINKERPOP-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201044#comment-15201044
]
ASF GitHub Bot commented on TINKERPOP-732:
------------------------------------------
GitHub user PommeVerte opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/271
TINKERPOP-732 .tree() serialization in GraphSON
I've had to upgrade jackson in `gremlin-shaded` to version `2.7.2` for this
fix. I've made the appropriate changes to the `NOTICE` files.
This makes `tree()` work with the `GraphSON` serializers. I've added tests
for `GraphSON` and `Gryo` + driver tests for `GraphSONMessageSerializer` and
`GraphSONMessageGremlinSerializer`
What I've done for testing:
- `mvn clean install` **OK**
- `mvn verify -DskipIntegrationTests=false -pl gremlin-server` **OK**
- Ran tests with the php driver against `application/json` **OK**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #271
----
commit c01f19708a56452c368919133bee38c0e00bd3a2
Author: Dylan Millikin <[email protected]>
Date: 2016-03-16T16:32:44Z
TINKERPOP-732 added support for tree() results to be serialized over
GraphSON
commit edb61f5e356dc30fc75a318bbf41e887f6bd361b
Author: Dylan Millikin <[email protected]>
Date: 2016-03-18T03:11:30Z
Added mentions to notice. Added tests and made a slight correction to
serialization
commit 2f32f0cf0e158a1a8a2c4fbdc4956bf4fd29fa14
Author: Dylan Millikin <[email protected]>
Date: 2016-03-18T05:02:38Z
removed some commented code
----
> gremlin-server GraphSON serializer issue with tree()
> ----------------------------------------------------
>
> Key: TINKERPOP-732
> URL: https://issues.apache.org/jira/browse/TINKERPOP-732
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.2-incubating
> Reporter: Dylan Millikin
> Assignee: Dylan Millikin
>
> When using the {{tree()}} step with a GraphSON serializer the server hangs
> (though I've seen some form of serialization errors in more complex scenarios
> over titan).
> The following works fine in the console but fails using the graphSON
> serializer:
> {code:java}
> g.V(1).repeat(out()).until(out().count().is(0)).tree() // fails with .next()
> as well
> {code}
> The following works without a problem though:
> {code:java}
> g.V(1).repeat(out()).until(out().count().is(0))
> {code}
> Here's the configuration file I use for these tests:
> {code}
> host: localhost
> port: 8182
> threadPoolWorker: 1
> gremlinPool: 8
> scriptEvaluationTimeout: 30000
> serializedResponseTimeout: 30000
> channelizer: org.apache.tinkerpop.gremlin.server.channel.WebSocketChannelizer
> graphs: {
> graph: conf/tinkergraph-empty.properties
> }
> plugins:
> - tinkerpop.tinkergraph
> scriptEngines: {
> gremlin-groovy: {
> imports: [java.lang.Math],
> staticImports: [java.lang.Math.PI],
> scripts: [scripts/generate-classic.groovy]}}
> serializers:
> - { className:
> org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0 }
> - { className:
> org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0, config: {
> serializeResultToString: true }}
> - { className:
> org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0 }
> - { className:
> org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0 }
> processors:
> - { className:
> org.apache.tinkerpop.gremlin.server.op.session.SessionOpProcessor, config: {
> sessionTimeout: 28800000 }}
> metrics: {
> consoleReporter: {enabled: true, interval: 180000},
> csvReporter: {enabled: true, interval: 180000, fileName:
> /tmp/gremlin-server-metrics.csv},
> jmxReporter: {enabled: true},
> slf4jReporter: {enabled: true, interval: 180000},
> gangliaReporter: {enabled: false, interval: 180000, addressingMode:
> MULTICAST},
> graphiteReporter: {enabled: false, interval: 180000}
> }
> threadPoolBoss: 1
> maxInitialLineLength: 4096
> maxHeaderSize: 8192
> maxChunkSize: 8192
> maxContentLength: 65536
> maxAccumulationBufferComponents: 1024
> resultIterationBatchSize: 64
> writeBufferHighWaterMark: 32768
> writeBufferHighWaterMark: 65536
> ssl: {
> enabled: false}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
