Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/253#issuecomment-194294442
This is probably a good fix, but as you can see Travis is failing the build
of your branch:
https://travis-ci.org/apache/incubator-tinkerpop/builds/114736921
```text
Failed tests:
HostTest.shouldConstructHost:38 expected:<ws://[localhost]:8182/gremlin>
but was:<ws://[127.0.0.1]:8182/gremlin>
```
Seems easy enough to fix that. Also, did you try running the gremlin
server integration tests? those are very important to ensure that nothing
breaks in this change. You just run:
```text
mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests
```
Finally, can you please give an example of not configuring the hosts
correctly? I currently get this:
```text
gremlin> cluster = Cluster.open('conf/remote.yaml')
localhostdfadf: unknown error
Display stack trace? [yN] y
java.lang.IllegalArgumentException: localhostdfadf: unknown error
at
org.apache.tinkerpop.gremlin.driver.Cluster$Builder.addContactPoint(Cluster.java:546)
at
org.apache.tinkerpop.gremlin.driver.Cluster$Builder.<init>(Cluster.java:297)
at
org.apache.tinkerpop.gremlin.driver.Cluster$Builder.<init>(Cluster.java:268)
at org.apache.tinkerpop.gremlin.driver.Cluster.build(Cluster.java:143)
at org.apache.tinkerpop.gremlin.driver.Cluster.open(Cluster.java:199)
at org.apache.tinkerpop.gremlin.driver.Cluster$open.call(Unknown Source)
```
Is that what you see? Can you show an example of what you get with your
change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
