Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/246#issuecomment-191368007
  
    I think this might be a good idea.  Can you please do a the following:
    
    1. Rebase this against the `tp31` branch - I think it can safely go into 
3.1.2 (rather than the 3.2.x line of code)
    2. Instead of modifying the constructor, can you please just add a new one 
and keep the old one? That way we don't break anyone's code. If the users 
chooses to not supply `GraphManager` you can just instantiate from `Settings`.
    
    Let's see what it looks like from that perspective. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to