[
https://issues.apache.org/jira/browse/TINKERPOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167371#comment-15167371
]
ASF GitHub Bot commented on TINKERPOP-958:
------------------------------------------
Github user rjbriody commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/242#issuecomment-188858152
1 Done
2
Upgrade Instructions:
The profile()-Step has been refactored into 2 steps - the ProfileStep and
the ProfileSideEffectStep. Users who previously used the profile()-Step in
conjunction with cap(TraversalMetrics.METRICS_KEY) can now simply omit the cap
step. Users who retrieved TraverseralMetrics from the side effects after
iteration can still do so, but will need to specify a side effect key when
using the profile()-Step.
CHANGELOG
Split existing profile()-Step into ProfileStep and ProfileSideEffectStep.
profile()-Step now emits TraversalMetrics without the need for cap()-Step.
3 I'm guessing this is outside the coverage of the tests? I'm not hooked up
to run Giraph or Spark (and don't have time to go down that rabbit hole). I
could definitely use some help here if testing those is required for merge.
> Improve usability of .profile() step.
> -------------------------------------
>
> Key: TINKERPOP-958
> URL: https://issues.apache.org/jira/browse/TINKERPOP-958
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Reporter: Bob Briody
> Assignee: Marko A. Rodriguez
> Fix For: 3.2.0-incubating
>
>
> The .profile() step is currently tedious to use. One must remember this
> entire string to activate profiling and cap off the result:
> "profile().cap(TraversalMetrics.METRICS_KEY)".
> This should be streamlined.
> -Additionally, if the TraversalMetrics are cap'd off the end of the traversal
> then this step and the duration it takes should be excluded from the metrics
> and timers.- (Moved to own ticket:
> https://issues.apache.org/jira/browse/TINKERPOP-1078)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
