Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-186226747
I've grown suspicious of this line:
https://github.com/apache/incubator-tinkerpop/pull/209/files#diff-8ae08149638a77bbb943e6bb8438cfb6R631
because you `awaitTermination` without calling `shutdown` first. Calling
`shutdownNow` after it doesn't indicate an orderly shutdown either and nothing
is done with the list of returned un-executed tasks....
that said, I don't think it really matters though because we actually got
that test much more stable on the `tp31` line since you originally branched
this. I just wanted to bring those points to your attention in case you had
comments. When I merge your branch to tp31 locally, those lines you added go
away.
I had some failures with integration tests last night, but solved the
problem this morning (bug in the latest tp31 branch). I'll need to re-run the
tests gain in full tonight after that fix. If all works, I can vote positively
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
