Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/206#issuecomment-174571662
  
    Couple of notes. 
    
    * Why is `Type` an enum?
    * `Type` will need to implement serializable.
    * Is `Type` the best name? Perhaps `TypePredicate`? We should really hide 
`Type` as the only way to get to it is via `P`.
    * I would not do the `String` model just yet. Stick with just a `Class` 
parameter until we think through fully what this means for other languages. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to