Github user gdelafosse commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/186#issuecomment-172799284
  
    You should enjoy this update : 
    - I simplify the gremlin-shaded pom thanks to the solution explained 
[here](https://issues.apache.org/jira/browse/FELIX-1184)
    The idea is to call sequentially the maven-shade-plugin to shade the 
dependencies, the maven-jar-plugin to unpack the shaded jar, and eventually the 
maven-bundle-plugin to compute the OSGI MANIFEST entries and repack the jar.
    - I implemented an integration test to test that germlin-core is a valid 
OSGI bundle.
    Unfortunately I don't manage to implement the same test for 
tinkerpop-gremlin because when I add my test dependencies it breaks the 
existing test (hamcrest Matchers classes are not found). I don't understand for 
the moment how the tinkerpop-gremlin tests work...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to