[
https://issues.apache.org/jira/browse/TINKERPOP3-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967420#comment-14967420
]
ASF GitHub Bot commented on TINKERPOP3-861:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/116#issuecomment-149957481
This is really solid work. The code is clean, the test cases are thorough.
* I am assuming you ran `mvn clean install`.
* Be sure to update CHANGELOG on merge.
* Are there other areas of the codebase that can leverage `NumberHelper`?
(perhaps email dev@ and lets discuss there after merge).
* This is potentially *breaking* if someone was relying on 0.5 * 1 to be 0.
:) ... Regardless add this to the upgrade docs too so people know.
VOTE +1.
> Solve "The Number Problem" for Operator (and follow on operators)
> -----------------------------------------------------------------
>
> Key: TINKERPOP3-861
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-861
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.1-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Daniel Kuppitz
> Fix For: 3.1.0-incubating
>
>
> This Gist says it all.
> https://gist.github.com/dkuppitz/e589e43763a3546586b3
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
