Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/116#issuecomment-149957481
This is really solid work. The code is clean, the test cases are thorough.
* I am assuming you ran `mvn clean install`.
* Be sure to update CHANGELOG on merge.
* Are there other areas of the codebase that can leverage `NumberHelper`?
(perhaps email dev@ and lets discuss there after merge).
* This is potentially *breaking* if someone was relying on 0.5 * 1 to be 0.
:) ... Regardless add this to the upgrade docs too so people know.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
