[jira] [Commented] (TINKERPOP-2840) Test Failures on NonDex

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/TINKERPOP-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645707#comment-17645707
 ] 

ASF GitHub Bot commented on TINKERPOP-2840:
-------------------------------------------

priyanka-28 opened a new pull request, #1898:
URL: https://github.com/apache/tinkerpop/pull/1898

   Tests in IteratorUtilsTest and ParameterizedGroovyTranslatorTest express 
non-deterministic behavior and change the order of the attributes. The fix is 
changing HashMap to LinkedHashMap and changing HashSet to LinkedHashSet to 
guarantee determinism.
   
   [Issue] (https://issues.apache.org/jira/browse/TINKERPOP-2840)
   
   After resolving the issues successfully, the tests pass with NonDex - 
   
   <img width="1041" alt="image" 
src="https://user-images.githubusercontent.com/52324780/206881584-f160ee65-3ea2-447b-8113-7ea7f7a112c3.png";>
   




> Test Failures on NonDex
> -----------------------
>
>                 Key: TINKERPOP-2840
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2840
>             Project: TinkerPop
>          Issue Type: Bug
>            Reporter: Priyanka Awatramani
>            Priority: Trivial
>             Fix For: 3.7.0
>
>         Attachments: image-2022-12-10-18-49-54-203.png, 
> image-2022-12-10-18-50-35-363.png, image-2022-12-10-18-51-06-752.png
>
>
> The tests 
> {*}org.apache.tinkerpop.gremlin.process.traversal.translator.ParameterizedGroovyTranslatorTest#shouldHandleSet{*},
>  
> *org.apache.tinkerpop.gremlin.util.iterator.IteratorUtilsTest#shouldConvertMapToIterator*
>  and 
> *org.apache.tinkerpop.gremlin.util.iterator.IteratorUtilsTest#shouldConvertMapToList*
>  passed using normal maven-test, but showed Non-deterministic behavior under 
> NonDex([https://github.com/TestingResearchIllinois/NonDex)] and thus failed. 
> Some of the error messages are:
> !image-2022-12-10-18-51-06-752.png!
>  
> !image-2022-12-10-18-50-35-363.png!
> and after some probing, I found the output from the test is not deterministic.
>  
> Steps to reproduce the failure:
> Install Nondex([https://github.com/TestingResearchIllinois/NonDex)] in the 
> environment. 
> Then cd to nifi repository, and run the following:
> {code:java}
> mvn install -pl gremlin-core -am -DskipTests
> mvn -pl gremlin-core test 
> -Dtest=org.apache.tinkerpop.gremlin.process.traversal.translator.ParameterizedGroovyTranslatorTest#shouldHandleSet
> mvn -pl gremlin-core edu.illinois:nondex-maven-plugin:1.1.2:nondex 
> -Dtest=org.apache.tinkerpop.gremlin.process.traversal.translator.ParameterizedGroovyTranslatorTest#shouldHandleSet{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)