[
https://issues.apache.org/jira/browse/TIKA-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070224#comment-18070224
]
ASF GitHub Bot commented on TIKA-4704:
--------------------------------------
Copilot commented on code in PR #2729:
URL: https://github.com/apache/tika/pull/2729#discussion_r3019893365
##########
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/StackTraceTest.java:
##########
@@ -65,7 +65,8 @@ public class StackTraceTest extends CXFTestBase {
private static final String UNPACK_CONFIG_TEMPLATE =
"/configs/cxf-unpack-test-template.json";
private static final ObjectMapper MAPPER = new ObjectMapper();
- private Path unpackTempDir;
+ @TempDir
+ static Path unpackTempDir;
Review Comment:
`unpackTempDir` no longer has an access modifier (package-private). This can
remain `private` even with `@TempDir`, and other tests keep TempDir fields
private (e.g.,
`tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java:65-66`). Consider
changing this to `private static Path unpackTempDir` to preserve encapsulation
and match existing conventions.
```suggestion
private static Path unpackTempDir;
```
> Avoid remaining temp files
> --------------------------
>
> Key: TIKA-4704
> URL: https://issues.apache.org/jira/browse/TIKA-4704
> Project: Tika
> Issue Type: Task
> Affects Versions: 3.3.0
> Reporter: Tilman Hausherr
> Priority: Minor
> Fix For: 4.0.0, 3.3.1
>
> Attachments: screenshot-1.png
>
>
> This is my temp directory after a successful build of tika 3. We should try
> to lessen this.
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
