Copilot commented on code in PR #2729:
URL: https://github.com/apache/tika/pull/2729#discussion_r3019893365
##########
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/StackTraceTest.java:
##########
@@ -65,7 +65,8 @@ public class StackTraceTest extends CXFTestBase {
private static final String UNPACK_CONFIG_TEMPLATE =
"/configs/cxf-unpack-test-template.json";
private static final ObjectMapper MAPPER = new ObjectMapper();
- private Path unpackTempDir;
+ @TempDir
+ static Path unpackTempDir;
Review Comment:
`unpackTempDir` no longer has an access modifier (package-private). This can
remain `private` even with `@TempDir`, and other tests keep TempDir fields
private (e.g.,
`tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java:65-66`). Consider
changing this to `private static Path unpackTempDir` to preserve encapsulation
and match existing conventions.
```suggestion
private static Path unpackTempDir;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
