[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810080#comment-17810080
]
ASF GitHub Bot commented on TIKA-4119:
--------------------------------------
tballison commented on code in PR #1556:
URL: https://github.com/apache/tika/pull/1556#discussion_r1463871190
##########
tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java:
##########
Review Comment:
Better not to include the whitespace changes unrelated to the javascript
issue. No need to modify, though. I'm guilty of this too occasionally. LOL...
Same goes for the improvements to the minShouldMatch tests
##########
README.md:
##########
@@ -20,7 +20,7 @@ Tika jars can be fetched from Maven Central or your favourite
Maven mirror.
**Tika 1.X reached End of Life (EOL) on September 30, 2022.**
-Tika is based on **Java 8** and uses the [Maven 3](https://maven.apache.org)
build system.
+Tika is based on **Java 11** and uses the [Maven 3](https://maven.apache.org)
build system.
Review Comment:
Probably better in a separate commit, but let's leave it. Same goes for
other improvements in this file.
##########
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java:
##########
@@ -135,7 +136,7 @@ private void testFile(String expected, String filename)
throws IOException {
private void testStream(String expected, String urlOrFileName, InputStream
in)
throws IOException {
- assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in);
+ assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!");
Review Comment:
This is a bug which we'll fix in main separately. Let's revert this here.
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -----------------------------------------------------------------------------------------
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
> Components: mime
> Reporter: Matthias Juchmes
> Priority: Major
> Labels: tika-3x
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
