kpumuk opened a new pull request, #3369:
URL: https://github.com/apache/thrift/pull/3369
<!-- Explain the changes in the pull request below: -->
This pull requests fixes and expands Ruby protocol benchmark, with the main
goal is to be able to optimize protocols and measure performance regressions.
Before this change (completely broken):
```
$ ruby protocol_benchmark.rb
Unable to load thrift_native extension. Defaulting to pure Ruby libraries.
protocol_benchmark.rb:35:in '<main>': uninitialized constant
Thrift::MemoryBuffer (NameError)
transport1 = Thrift::MemoryBuffer.new
^^^^^^^^^^^^^^
Did you mean? Thrift::MemoryBufferTransport
```
## Major changes
* Fixed incompatibilities in the structs
* Added pure-ruby option to run the harness
* Added compact and JSON protocols support
* CLI configuration for number of runs for both small and large payloads, as
well as scenario selector for targeted runs
* Machine readable `--json` output.
Last two items allow to hook the benchmark script into
[autoresearch](https://github.com/karpathy/autoresearch)-style loops to
fine-tune the protocol implementation.
I am currently using the benchmark in
https://issues.apache.org/jira/browse/THRIFT-5938, and was able to catch a
regression in the recursion depth enforcement.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
