aglinxinyuan commented on PR #3753: URL: https://github.com/apache/texera/pull/3753#issuecomment-3413842309
> > > First of all, we should start to add more tests. Secondly, those simple initiation tests can at least help us to know if a component can be initialized or not, which is at least helpful when we upgrade dependencies. > > > > > > Anyway, we can blame the existing tests, they can be improved. but that's not a reason not to add test here. > > > > We already have initiation tests and the other tests for the workflow-editor. I'm not adding any new component in this PR. > > That's good. Can we add some tests against your new code? That's why did I mentioned my second point in my earlier comment. In this PR, I'm drawing some shape in html with a library. It's not easy to compare drawing in joints with our current test framework, and even it's possible, it's hard to define what's a correct drawing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
