chenlica commented on code in PR #3715:
URL: https://github.com/apache/texera/pull/3715#discussion_r2399530064
##########
deployment/k8s/texera-helmchart/files/texera_ddl.sql:
##########
@@ -264,13 +264,14 @@ CREATE TABLE IF NOT EXISTS public_project
-- dataset
CREATE TABLE IF NOT EXISTS dataset
(
- did SERIAL PRIMARY KEY,
- owner_uid INT NOT NULL,
- name VARCHAR(128) NOT NULL,
- is_public BOOLEAN NOT NULL DEFAULT TRUE,
+ did SERIAL PRIMARY KEY,
+ owner_uid INT NOT NULL,
+ name VARCHAR(128) NOT NULL,
+ repository_name VARCHAR(128),
+ is_public BOOLEAN NOT NULL DEFAULT TRUE,
is_downloadable BOOLEAN NOT NULL DEFAULT TRUE,
- description VARCHAR(512) NOT NULL,
- creation_time TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
+ description VARCHAR(512) NOT NULL,
+ creation_time TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
Review Comment:
We do NOT want to include such style changes in this PR as they have nothing
to do with this PR and they can make the PR harder to review. Please revert
it as suggested by @bobbai00 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
