aicam commented on code in PR #3736:
URL: https://github.com/apache/texera/pull/3736#discussion_r2353007811
##########
core/gui/src/app/dashboard/component/admin/user/admin-user.component.ts:
##########
@@ -196,6 +196,10 @@ export class AdminUserComponent implements OnInit {
return Date.now() - lastMs < active_window;
}
+ getAccountCreation(user: User): number {
+ return user.accountCreation * 1000;
Review Comment:
This logic of `* 1000` is happening multiple time, I remember you did it in
`last_active_time` as well, even used in other places like
`core/gui/src/app/common/service/user/user.service.ts`, Im worried that other
contributors get confused, please define `export type Second = number` in
`core/gui/src/app/common/type/user.ts` and specify the return of the function
as `Second` this way developers understand what the number means, later, we
might raise a PR to fix it in other functions as well.
##########
core/gui/src/app/common/type/user.ts:
##########
@@ -44,6 +44,7 @@ export interface User
googleAvatar?: string;
comment: string;
lastLogin?: number;
+ accountCreation: number;
Review Comment:
Please make this optional, there are many components using User type and
don't set it or need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
