Copilot commented on code in PR #3689:
URL: https://github.com/apache/texera/pull/3689#discussion_r2299288176
##########
.github/workflows/github-action-build.yml:
##########
@@ -79,34 +79,52 @@ jobs:
env:
JAVA_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M
-Dfile.encoding=UTF-8
JVM_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M
-Dfile.encoding=UTF-8
+
+ services:
+ postgres:
+ image: postgres
+ env:
+ POSTGRES_PASSWORD: postgres
+ ports:
+ - 5432:5432
+ # Add a health check so steps wait until Postgres is ready
+ options: >-
+ --health-cmd="pg_isready -U test -d texera_db"
Review Comment:
The health check uses username 'test' and database 'texera_db', but the
PostgreSQL service is configured with default username 'postgres' and no
specific database. This health check will likely fail. Change to
`--health-cmd=\"pg_isready -U postgres\"`
```suggestion
--health-cmd="pg_isready -U postgres"
```
##########
.github/workflows/github-action-build.yml:
##########
@@ -79,34 +79,52 @@ jobs:
env:
JAVA_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M
-Dfile.encoding=UTF-8
JVM_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M
-Dfile.encoding=UTF-8
+
+ services:
+ postgres:
+ image: postgres
Review Comment:
Using 'postgres' without a specific tag will pull the latest version, which
could introduce breaking changes. Consider pinning to a specific version like
'postgres:15' for reproducible builds.
```suggestion
image: postgres:15
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
