This looks good to me. On Wed, Apr 3, 2019 at 4:00 PM Ian Dunlop <[email protected]> wrote:
> Hello, > > > > Adding the gradle download into the travis file appears to work. See > https://travis-ci.org/apache/incubator-taverna-mobile/builds/515120359. I > rolled the gradle changes back out of master and put them in branch > ian_travis_gradle. If everyone thinks this is an ok direction then we can > merge back into master and go for RC2 without the binary. > > > > Cheers, > > > > Ian > > > > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for > Windows 10 > > > > *From: *Ian Dunlop <[email protected]> > *Sent: *02 April 2019 18:10 > *To: *Sagar <[email protected]> > *Cc: *[email protected]; Stian Soiland-Reyes > <[email protected]> > *Subject: *Re: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > > > Hello > > > > The first answer on > https://stackoverflow.com/questions/42818269/is-gradlew-mandatory-for-travis-ci-to-work/43493907 > suggests > that you can get travis to create a gradle wrapper for you. We could try > that and see if it works. I'm just trying to make the process simple. For > Devs you only need to install gradle and run the gradle wrapper command > once and then you are all setup. I guess we could also write a shell script > to create the bundle for us. Open to all suggestions. > > Feel free to back out any of my changes if they are causing you problems > but we need to think of a solution. > > > > Cheers > > > > Ian > > > > On Tue, 2 Apr 2019, 18:00 Ian Dunlop, <[email protected]> wrote: > > Hello > > > > That makes it a tricky problem to solve. If we can't rely on the GitHub > tag for the bundle then we will need to create our own after cloning and > removing the gradle folder. Can Travis create a gradle wrapper before > building? I'm happy to go with creating our own bundle but it is more work. > Remove git folder, remove gradle etc. > > > > Cheers > > > > Ian > > > > On Tue, 2 Apr 2019, 17:15 Sagar, <[email protected]> wrote: > > Due to removing the wrapper. We will not able to build the project. It is > required to build the android code. Travis is also failing because of this. > > > > On Tue, Apr 2, 2019 at 8:53 PM Ian Dunlop <[email protected]> wrote: > > Hello > > > > I just commited some fixes. Hopefully all the files have the correct > headers now. I also removed the gradle wrapper. Now you have to create the > wrapper yourself when you first clone the project. Seems like the easiest > way to avoid the binary issue. I think I've got the issues fixed so I can > try and put RC2 together soon. Hopefully my key issue is fixed as well. > Maybe someone could check for me. > > > > Cheers, > > > > Ian > > > > On Tue, 2 Apr 2019, 15:10 Sagar, <[email protected]> wrote: > > @Ian Dunlop <[email protected]> Are you working on the issues or do I > make the change? > > > > > > > > On Mon, Apr 1, 2019 at 9:41 PM Ian Dunlop <[email protected]> wrote: > > Hello, > > The key fingerprint is the same as listed in the KEYS file. Does that mean > the key is the same? > > Cheers, > > Ian > > Sent from Mail for Windows 10 > > From: Stian Soiland-Reyes > Sent: 01 April 2019 16:43 > To: Ian Dunlop > Cc: [email protected] > Subject: RE: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > You'll also need to update the KEYS file in dist. > > On Mon, 1 Apr 2019 13:39:40 +0100, Ian Dunlop <[email protected]> > wrote: > > Hello, > > > > @Sagar don’t forget to give it a +1 on the [VOTE] thread if you think it > passes all the Apache release criteria. I think I just posted my VOTE to > the DISCUSS thread – not sure message threading is working correctly in my > email client. Apologies for any confusion. > > > > I’ve updated my key on the keyservers (gpg & ubuntu though they should > both sync anyway). Let’s see if that fixes things because I’m sure I’ve > updated them before. > > I guess we should give them 24 hours to sort themselves out and then gpg > --refresh-keys to update your local keys. > > > > > -- > > > > Warmest regards > > Sagar > > Software Developer > > Lattice Innovations Pvt. Ltd. > > > > > -- > > > > Warmest regards > > Sagar > > Software Developer > > Lattice Innovations Pvt. Ltd. > > > -- Warmest regards Sagar Software Developer Lattice Innovations Pvt. Ltd.
