Github user stain commented on a diff in the pull request:

    
https://github.com/apache/incubator-taverna-language/pull/42#discussion_r209235462
  
    --- Diff: 
taverna-scufl2-cwl/src/main/java/org/apache/taverna/scufl2/cwl/CWLParser.java 
---
    @@ -22,16 +22,10 @@
     import java.util.Set;
     import java.util.HashSet;
     
    -import org.apache.taverna.scufl2.api.core.Workflow;
    -import org.apache.taverna.scufl2.api.core.Processor;
    -
    -import org.apache.taverna.scufl2.api.port.InputWorkflowPort;
    -import org.apache.taverna.scufl2.api.port.OutputWorkflowPort;
    -import org.apache.taverna.scufl2.api.port.InputProcessorPort;
    -import org.apache.taverna.scufl2.api.port.OutputProcessorPort;
    -
     import com.fasterxml.jackson.databind.JsonNode;
     
    +import org.apache.taverna.scufl2.cwl.components.*;
    --- End diff --
    
    No, don't use `.*` imports, that can be very fragile and confusing, in 
particular once you get two `*` imports that have the same class name.


---

Reply via email to