Hi justin: Thanks very much for your review, vue3-vite3-template[1] is based on vue-vben-admin[2] , This point is mentioned in his README[3] , We only copied code from the vue-vben-admin[2] project, We also found many other projects some codes copied from vue-vben-admin[2]. vue-vben-admin[2] is the original source.
[1] https://github.com/zqy-cli/vue3-vite3-template [2] https://github.com/vbenjs/vue-vben-admin [3] https://github.com/zqy-cli/vue3-vite3-template/blob/main/README.md?plain=1#L65 Best, Huajie Wang Justin Mclean <[email protected]> 于2023年11月21日周二 06:32写道： > Hi, > > It also looks like a large number of files have been copied from [1] > > Justin > > 1. https://github.com/zqy-cli/vue3-vite3-template > > > > On 20 Nov 2023, at 5:43 pm, Huajie Wang <[email protected]> wrote: > > hi @justin: > > In the last round of voting, you left some comments, as follows: > > Files misisng from license include [1], and these files which may have > incorrect headers as well [2] (this comes from IconFont?) and [3] (Vue3 > template?). Are there any other files from StreamX that have ASF headers? Are > [2][3] really ASF files? Are there other files that have been copied here? It > might also be that the ASF headers have been placed on other files where they > should not, e.g. ant design files. >> >> >> 1. >> ./streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/aspect/StreamParkAspect.java >> 2. >> ./streampark-console/streampark-console-webapp/src/components/Icon/src/SvgIcon.vue >> 3../streampark-console/streampark-console-webapp/src/components/Form/src/hooks/useFormEvents.ts >> >> > We have fixed them and there are relevant PRs[1][2][3]. Could you help us > check if these issues have been resolved? Thanks very much. > [1] https://github.com/apache/incubator-streampark/pull/3318 > > [2] https://github.com/apache/incubator-streampark/pull/3319 > > [3] https://github.com/apache/incubator-streampark/pull/3323 > > Best, > Huajie Wang > > > > Huajie Wang <[email protected]> 于2023年11月20日周一 14:14写道： > >> +1 (binding) >> >> >> I have checked: >> >> - Download StreamPark is valid. - LICENSE and NOTICE present - DISCLAIMER >> present - GPG sign is correct "gongzhongqiang (for apache StreamPark >> release create at 20231024) <***@apache.org>" - Checksum 512 match - >> Build with JDK 8 & Scala 2.11/2.12 on macOS 14.1.1 (23B81) - No binary >> files in the source release >> >> >> Best, >> Huajie Wang >> >> >> >> gongzhongqiang <[email protected]> 于2023年11月19日周日 16:50写道： >> >>> Hello StreamPark Community: >>> >>> This is a call for vote to release Apache StreamPark(Incubating) version >>> release-2.1.2-RC3. >>> >>> Apache Streamark,Make stream processing easier! easy-to-use streaming >>> application development framework and operation platform. >>> >>> Release notes: >>> https://streampark.apache.org/download/release-note/2.1.2/ >>> >>> The release candidates: >>> https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.2-RC3/ >>> >>> Git tag for the release: >>> https://github.com/apache/incubator-streampark/releases/tag/v2.1.2-rc3 >>> >>> The artifacts signed with PGP key [FAB07811], corresponding to [ >>> [email protected]], that can be found in keys file: >>> https://downloads.apache.org/incubator/streampark/KEYS >>> >>> The vote will be open for at least 72 hours or until the necessary number >>> of votes are reached. >>> >>> Please vote accordingly: >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> *Valid check is a requirement for a vote. *Checklist for reference: >>> >>> [ ] Download StreamPark is valid. >>> [ ] Checksums and PGP signatures are valid. >>> [ ] Source code distributions have correct names matching the current >>> release. >>> [ ] LICENSE and NOTICE files are correct for each StreamPark repo. >>> [ ] All files have license headers if necessary. >>> [ ] No compiled archives bundled in source archive. >>> [ ] Can compile from source. >>> >>> More detail checklist please refer: >>> >>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >>> >>> Steps to validate the release，Please refer to: >>> https://streampark.apache.org/community/release/how_to_verify_release >>> >>> How to Build: >>> >>> 1. cd incubator-streampark >>> 2. sh ./build.sh >>> >>> Thanks! >>> >> >
