Hi, team, This discussion has been going on for some time and a lot of suggestions have been received from developers of community, which makes it better. Thank you for all the previous comments.
I completed a draft [1] based on the existing comments on the discussion page [2]. Looking forward to your suggestions! [1] https://github.com/apache/incubator-streampark/discussions/2915#discussioncomment-6793456 [2] https://github.com/apache/incubator-streampark/discussions/2915 Best, Yuepeng On 2023/08/06 02:12:32 Huajie Wang wrote: > Thank you very much for driving the improvement of check style. It is great > and has a significant impact on the quality improvement of the project. I > see many excellent suggestions in the discussions, and I would like to add > a few points: > > 1. 1. Set serialVersionUID to 1L for all classes, following Flink's > serialVersionUID > 2. 2. The number of lines in a method should not be too long > 3. 3. Standardize the comments on methods. > > We can summarize these specifications into official website documents as > development specifications. > > > Best, > Huajie Wang > > > > Yuepeng Pan <[email protected]> 于2023年8月6日周日 07:24写道： > > > Hi, Achao. > > > > > > > > Thanks for driving the discussion. > > > > > > I have read the discussion page[1]. Undoubtedly, some code-style issues in > > the project have been pointed out on the page, which is very helpful for us > > to organize common rules from common problems. > > > > > > In addition, we can also learn from the rules of other mature projects, > > continuously improve the rules and execute them in response to newly > > discovered problems. It will be a clear document, and all related work is > > roughly divided into two parts. The one part of it is documentation for the > > website. The rest is continuous Programming style improvement. > > > > > > I'm looking forward to the progress of this work and willing to work > > together to promote it. > > > > > > > > [1] https://github.com/apache/incubator-streampark/discussions/2915 > > > > > > > > Best, > > Yuepeng Pan. > > > > > > > > > > > > At 2023-08-05 22:35:48, "chao a" <[email protected]> wrote: > > >Hey Team, > > > > > > > > >Hope ya'll are doing well. > > > > > >Just a quick one, need your thoughts on a couple of things related to our > > >Streampark project: > > > > > > > > >1. Let's talk about how we're currently coding and getting stuff done. > > > > > >2. I've got a draft of new rules. Would love to get your ideas on this. > > > > > > > > >As our project is growing like crazy, it's super important to keep our > > code > > >clean and simple. Any insights you have on coding issues or improvements > > >would be a massive help. > > > > > > > > >Also, we've got some new rules in place to help us work smarter. Can't > > wait > > >to hear what ya'll think about this. > > > > > >https://github.com/apache/incubator-streampark/discussions/2915 > > > > > > > > >Your help will really up our coding game and make us a lot more efficient. > > > > > > > > >Thanks in advance for your thoughts. Looking forward to hearing you. > > > > > > > > >Cheers, > > > > > >Achao > > >
