The GitHub Actions job "Java CI with Maven" on stormcrawler.git/apache-http has 
failed.
Run started by GitHub user rzo1 (triggered by rzo1).

Head commit for run:
b43e4f28a8a0377c97eacd21c1c1b900889811be / Richard Zowalla <[email protected]>
Fix bugs and resource leaks in Apache HttpClient protocol implementation

The proxy race condition fix (a08a456b) introduced two regressions:

The local builder for proxied requests lost:
Default headers
User-Agent
A new CloseableHttpClient was created on every request, even when no proxy was 
used
Fixes applied
Store userAgent and defaultHeaders as fields
Pass these fields to the proxy builder
Build the client once in configure() and reuse it for non-proxy requests
Additional fixes
Fix toByteArray() returning null when the entity input stream is null
Close the static CONNECTION_MANAGER in cleanup()
Wrap the entity InputStream in a try-with-resources block

Report URL: https://github.com/apache/stormcrawler/actions/runs/23862426730

With regards,
GitHub Actions via GitBox

Reply via email to