sigee commented on code in PR #1834:
URL: https://github.com/apache/stormcrawler/pull/1834#discussion_r2969961945
##########
core/src/main/java/org/apache/stormcrawler/bolt/JSoupParserBolt.java:
##########
@@ -387,7 +387,7 @@ public void execute(Tuple tuple) {
return;
}
} catch (MalformedURLException e) {
- LOG.error("MalformedURLException on {}", url);
+ LOG.error("Exception on {}", url, e);
Review Comment:
The log message here was updated to `"Exception on {}"`, but the catch
clause still catches `MalformedURLException` specifically. Comparing this to
lines 519/522, where both the catch and the log were updated to the generic
`Exception` — would it make sense to apply the same treatment here for
consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
