Hello everyone, I was having a look at the FieldValueFeature class in the ltr module: *org.apache.solr.ltr.feature.FieldValueFeature*. I notice that in this class, a *useDocValuesForStored* boolean variable is declared and initialized to true. This variable is never overwritten except that in the deprecated class *org.apache.solr.ltr.feature.LegacyFieldValueFeature#LegacyFieldValueFeature* and in the corresponding deprecated test: *org.apache.solr.ltr.feature.TestLegacyFieldValueFeature*. It is however used in an *if* condition of this method *org.apache.solr.ltr.feature.FieldValueFeature.FieldValueFeatureWeight#scorer* .
Would it be safe to remove it completely since it is always true? Suppose it is a condition we need to check, why not to use the *org.apache.solr.schema.SchemaField#useDocValuesAsStored* method instead? Thank you, *Anna Ruggero* R&D Machine Learning / Software Engineer, Search Consultant e-mail: a.rugg...@sease.io *Sease* - Information Retrieval Applied Consulting | Training | Open Source Sease.io <http://sease.io/> LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter <https://twitter.com/seaseltd> | Youtube <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> | Github <https://github.com/seaseltd>
